Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Voicing] implement TickMarkRadioButtonGroup #384

Closed
zepumph opened this issue May 3, 2021 · 7 comments
Closed

[Voicing] implement TickMarkRadioButtonGroup #384

zepumph opened this issue May 3, 2021 · 7 comments
Assignees
@terracoda
Labels
dev:voicing status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented May 3, 2021

From #363
@zepumph zepumph self-assigned this May 3, 2021
zepumph added a commit that referenced this issue May 3, 2021
@zepumph
add activation voicing alerts for TickMarkViewRadioButtonGroup, #384
3f21ef1
@zepumph
Copy link
Member Author

zepumph commented May 3, 2021

Activation supported above, with a refactor of the switch. . . case for interactive description alerts.

@zepumph zepumph mentioned this issue May 3, 2021
Closed
zepumph added a commit that referenced this issue May 3, 2021
@zepumph
add cancelOther and have focus event handle object respones, #384 and p…
ff895fd 
…hetsims/sun#699
@zepumph
Copy link
Member Author

zepumph commented May 3, 2021

Much of this work was done in phetsims/sun#699.

Currently in the preferences branch in sun has commits to RectangularRadioButtonGroup that work well for focus and keyboard interaction, but don't give the object response for mouse/touch. Marking for a11y dev meeting to discuss with @jessegreenberg tomorrow.

@terracoda
Copy link
Contributor

@zepumph, this issue might be stale. I didn't open it. TickMarkRadioGroup is ready from a design perspective, when you are ready to implement.

zepumph referenced this issue Feb 7, 2022
@zepumph
add voicing to TickMarkViewRadioButtonGroup, #363
afb4781
@zepumph
Copy link
Member Author

zepumph commented Feb 7, 2022

I got something working in master for this, but I'm pretty sure we will want to use this chance to update common code over in phetsims/sun#699.

@zepumph zepumph mentioned this issue Feb 7, 2022
Closed
@zepumph
Copy link
Member Author

zepumph commented Feb 11, 2022

Don't forget about on-focus, we need more than just listening to the Property changing.

zepumph added a commit that referenced this issue Feb 23, 2022
@zepumph
Use common code voicing for radio buttons, #384
775e154
@zepumph
Copy link
Member Author

zepumph commented Feb 23, 2022

Ok, I have added this to common code, and removed the custom implementation in TickMarkRadioButtonGroup. @terracoda please review after a thorough cleaning of the cache (I will pull all on phettest)

@zepumph zepumph assigned terracoda and unassigned zepumph Feb 23, 2022
@terracoda
Copy link
Contributor

The Tick Marks radio button responses sound great. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terracoda terracoda

Labels
dev:voicing status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@terracoda @zepumph