Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staccato sound bug #179

Closed
zepumph opened this issue Sep 15, 2020 · 2 comments
Closed

Staccato sound bug #179

zepumph opened this issue Sep 15, 2020 · 2 comments
Assignees
@jbphet
Labels
status:ready-for-review type:bug Something isn't working

Comments

@zepumph
Copy link
Member

zepumph commented Sep 15, 2020

From #174 (comment)

some of the repeating sounds are mixed up and different pitches.

To reproduce:
1st screen
challenge 1
move right value to 3
@zepumph zepumph added the type:bug Something isn't working label Sep 15, 2020
@zepumph zepumph self-assigned this Sep 15, 2020
zepumph added a commit that referenced this issue Sep 15, 2020
@zepumph
fix "e" staccator sound, #179
b23397e
@zepumph
Copy link
Member Author

zepumph commented Sep 15, 2020

Good catch @jbphet! I traced it back to a naming issue, but when I redownloaded e-001 from https://drive.google.com/drive/u/1/folders/10-kHZgFSu0HEMUfNk0zEn0cvPRK8gFXg and it sounds correct now. Over to @jbphet to confirm on master.

@zepumph zepumph assigned jbphet and unassigned zepumph Sep 15, 2020
@jbphet
Copy link
Contributor

jbphet commented Oct 12, 2020

Yep, seems fine on master. Closing.

@jbphet jbphet closed this as completed Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbphet jbphet

Labels
status:ready-for-review type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbphet @zepumph