-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding standard UI sounds #13
Comments
@jbphet and I turned on build in UI sounds yesterday. We can add the pickup/drop sound next. |
KeyboardDragListener fires start/end for each arrow key interaction. This made grab/release sounds feel really weird, so I moved them instead to be based on focus/blur events. This sounds much nicer. I also added these to the bar screen. This issue is ready for review. |
From design meeting, let's take out the pickup and drop sounds from the bar screen. |
@jbphet @zepumph
Please also add the standard UI sounds to the radio buttons, the reset all button, and the pickup/drop of the freely moving objects, as well as the screen selection buttons.
Note - the tolerance slider is just to support design, it will not be in a final version of the sim, so don't add sound to that slider.
The text was updated successfully, but these errors were encountered: