Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding standard UI sounds #13

Closed
emily-phet opened this issue Apr 12, 2020 · 4 comments
Closed

Adding standard UI sounds #13

emily-phet opened this issue Apr 12, 2020 · 4 comments
Assignees

Comments

@emily-phet
Copy link

emily-phet commented Apr 12, 2020

@jbphet @zepumph
Please also add the standard UI sounds to the radio buttons, the reset all button, and the pickup/drop of the freely moving objects, as well as the screen selection buttons.

Note - the tolerance slider is just to support design, it will not be in a final version of the sim, so don't add sound to that slider.

@zepumph
Copy link
Member

zepumph commented Apr 14, 2020

@jbphet and I turned on build in UI sounds yesterday. We can add the pickup/drop sound next.

@jbphet
Copy link
Contributor

jbphet commented Apr 14, 2020

@zepumph and I worked on this together today and the sounds are now all in place with the exception of the grab/release sounds for the second screen, which @zepumph said he'll take care of. Unassigning.

@jbphet jbphet removed their assignment Apr 14, 2020
@zepumph
Copy link
Member

zepumph commented Apr 14, 2020

KeyboardDragListener fires start/end for each arrow key interaction. This made grab/release sounds feel really weird, so I moved them instead to be based on focus/blur events. This sounds much nicer. I also added these to the bar screen. This issue is ready for review.

@zepumph zepumph assigned emily-phet and unassigned zepumph Apr 14, 2020
@zepumph
Copy link
Member

zepumph commented Apr 14, 2020

From design meeting, let's take out the pickup and drop sounds from the bar screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants