Skip to content

Commit

Permalink
allow eslint-disable-line in bad-text lint rules, phetsims/chipper#1224
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed May 9, 2022
1 parent d573059 commit a1e0d01
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 3 additions & 3 deletions js/common/view/RAPMediaPipe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ class RAPMediaPipe extends MediaPipe {
// These are along the center of a hand, about where we have calibrated the hand icon in RAP, see https://google.github.io/mediapipe/solutions/hands.html#hand-landmark-model
HAND_POINTS.forEach( index => {
const point = handMarkerPositions[ index ];
assert && assert( typeof point.x === 'number' );
assert && assert( typeof point.y === 'number' );
assert && assert( typeof point.z === 'number' );
assert && assert( typeof point.x === 'number' ); // eslint-disable-line bad-typescript-text
assert && assert( typeof point.y === 'number' ); // eslint-disable-line bad-typescript-text
assert && assert( typeof point.z === 'number' ); // eslint-disable-line bad-typescript-text
const yPosition = mediaPipeOptions.yAxisFlippedProperty.value ? point.y : 1 - point.y;
const xPosition = mediaPipeOptions.xAxisFlippedProperty.value ? point.x : 1 - point.x;
const position = new Vector3( xPosition, yPosition, 1 - point.z );
Expand Down
2 changes: 0 additions & 2 deletions js/common/view/RAPTickMarkLabelsNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,6 @@ class RAPTickMarkLabelsNode extends Node {
private updateUnitLabels( horizontalSpacing: number ): void {
this.children = [];

assert && assert( typeof horizontalSpacing === 'number', 'Unit Labels only supported for horizontal lines' );

let i = 0;

for ( let y = 0; y <= this.totalHeight; y += horizontalSpacing ) {
Expand Down

0 comments on commit a1e0d01

Please sign in to comment.