Skip to content

Commit

Permalink
edge responses are not handled here, #457
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Apr 22, 2022
1 parent ce8d4d8 commit 9ce6bac
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions js/common/view/describers/HandPositionsDescriber.ts
Original file line number Diff line number Diff line change
Expand Up @@ -337,15 +337,12 @@ class HandPositionsDescriber {

// TODO: capitalized is currently always used, but it would be nice to improve the implementation for voicing context responses, https://github.com/phetsims/ratio-and-proportion/issues/461
getBothHandsDistance( capitalized: boolean, providedOptions?: HandContextResponseOptions ): string {
const options = optionize<HandContextResponseOptions>()( {
supportGoBeyondEdgeResponses: true,
const options = optionize<HandContextResponseOptions, Omit<HandContextResponseOptions, 'supportGoBeyondEdgeResponses'>>()( {

// By default, let the describer decide if we should have distance progress or region
distanceResponseType: DistanceResponseType.COMBO
}, providedOptions );

// TODO: manage edge response here for both hands instead of in the BothHandsDescriber: https://github.com/phetsims/ratio-and-proportion/issues/457

switch( options.distanceResponseType ) {
case DistanceResponseType.COMBO:
return this.getBothHandsComboDistance( capitalized );
Expand Down

0 comments on commit 9ce6bac

Please sign in to comment.