fix javascript number imprecision when snapping to tick mark, #457

phetsims · May 25, 2022 · 94b175f · 94b175f
1 parent 42aa75d
commit 94b175f
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/js/common/view/RatioHalf.ts b/js/common/view/RatioHalf.ts
@@ -270,7 +270,9 @@ class RatioHalf extends Rectangle {
         // iterate through model values of each tick mark
         for ( let i = TOTAL_RANGE.min; i < TOTAL_RANGE.max; i += tickMarkStep ) {
           if ( Math.abs( yValue - i ) < tickMarkStep * SNAP_TO_TICK_MARK_THRESHOLD ) {
-            return i;
+
+            // Bug occurs when dragging to the top with tick marks enabled, the value is 1, but snaps to .999999 unless rounded
+            return rapConstants.toFixed( i ); // eslint-disable-line bad-sim-text
           }
         }
       }