-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Preferences Menu screen reader accessible #441
Comments
Noting that @terracoda thinks the current descriptions should work for both Interactive Description and Voicing. There might be minor gaps. |
OK, PDOM content has been added for the quadrilateral sound options. I will instrument the input tab once #315 is done. |
@jessegreenberg and I met to discuss a more general strategy for the on-boarding the team to making screen reader accessible a Preferences Menu.
This comment might need to move to a new issue. |
@terracoda Just a thought - I would suggest keeping tips very minimal and focused primarily on how to evaluate a drafted text description. I think we will encourage novice description designers in particular to use LLMs to help them generate initial draft descriptions, so evaluating and tweaking will be the most challenging human task. We can provide examples to feed to LLM to support generating reasonable initial text. |
There's lots of information in the description course, but nothing about how the current Preferences Menu works, so yes, it will be brief. I am sure LLMs can be helpful. |
We'll follow-up on documentation in issue phetsims/phet-info#213 |
For the quadrilateral specific stuff, descriptions for Voicing were added in #315 so this is no longer blocked. |
The input tab of Preferences for Quadrilateral is sounding good to me with NVDA in Chrome and Firefox. I read and could use both media pipe and BLE related controls. @terracoda would you like to review? |
I checked all tabs. Everything sounds pretty good with VoiceOver in Safari, and in Chrome I think it sounds better Tabs, so just saying so ;-) Small Issue:
Confusing Issue
Questions:
I don't think this should stop publication. A fix might not be straight forward, but could you investigate to see why focus stays on the slider. Maybe you already know why. |
The direct screen reader accessibility is good otherwise, nice work. |
OK, this is now an h3.
@terracoda and I met to investigate this. We created a simple test cased where we verified that this behavior is typical for VoiceOver and happens in contexts outside of PhET. <!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<title>Title</title>
</head>
<body>
<label for="my-slider">My Slider</label>
<input id="my-slider" type="range" min="0" max="10">
<p>This is a test paragraph, with some descriptive content.</p>
<button>Button!</button>
</body>
</html> |
@terracoda is there anything else for this issue? |
Nope. You got the h3 in, and I can access it. And we won't fix the somewhat confusing focus issue since it seems like that is how VoiceOver works by default in both Chrome and Safari. NVDA and JAWS have different modes, so those screen readers work differently. If issues come up in future interviews with participants who use VoiceOver, we can revisit. |
Closing. |
I discussed with @emily-phet and @kathy-phet, and there was agreement that it makes sense to make the Preferences Menu screen reader accessible when a simulation is implemented with Alternative Input. Reasoning is once a sim is implemented with a PDOM, it is navigable with a screen reader. Even if the sim doe snot have interactive description it makes sense to keep the Preferences Menu accessible in case there are any features or particular preferences that need to be turned on or adjusted.
For Quad this means we need to :
And additionally, if possible
The text was updated successfully, but these errors were encountered: