Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Mouse" in Keyboard Shortcuts dialog should be translatable #323

Closed
Nancy-Salpepi opened this issue Jan 10, 2023 · 4 comments
Closed

"Mouse" in Keyboard Shortcuts dialog should be translatable #323

Nancy-Salpepi opened this issue Jan 10, 2023 · 4 comments
Assignees
Labels
type:bug Something isn't working type:i18n

Comments

@Nancy-Salpepi
Copy link

For phetsims/qa#879, with string tests, the word "mouse" in the Keyboard Shortcuts dialog never changes.
Screenshot 2023-01-10 at 1 13 33 PM

Confirmed with @jessegreenberg on Slack that "mouse" should indeed by translatable.

@jessegreenberg
Copy link
Contributor

Thanks @Nancy-Salpepi! Here is the dialog now:
image

OK to close?

@Nancy-Salpepi
Copy link
Author

Looks good @jessegreenberg. I also checked the other string tests.

One last question before I close this....is this statement non translatable because Voicing only works in English?
Screenshot 2023-01-10 at 5 41 01 PM

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Jan 10, 2023

Yes exactly. When running in a non-English language or where Voicing isn't supported that row in the dialog won't be shown at all. (Can see with ?supportsVoicing=false.

Thanks for checkinbg.

@Nancy-Salpepi
Copy link
Author

Ok thanks! I like that parameter!
Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:i18n
Projects
None yet
Development

No branches or pull requests

2 participants