Skip to content

Commit

Permalink
remove review comment about pick, I don't know that it simplifies thi…
Browse files Browse the repository at this point in the history
…ngs and doesn't seem to work well for nested model components, see #398
  • Loading branch information
jessegreenberg committed Mar 21, 2023
1 parent 2699388 commit c80ab3b
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions js/quadrilateral/view/QuadrilateralScreenView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,7 @@ export default class QuadrilateralScreenView extends ScreenView {
this.quadrilateralDescriber, {
tandem: tandem.createTandem( 'quadrilateralNode' )
} );

// REVIEW: In this case and others like it, we are plucking several attributes from the model, (potentially) renaming them
// and passing them through. This makes it difficult to trace back to the source.
// An alternative is to pass the entire model through, and use TypeScript to narrow what is accessible
// Note the visibilityModel is also part of the model.
// - Cool, Ill review and update to use pick

const diagonalGuidesNode = new QuadrilateralDiagonalGuidesNode(
model.quadrilateralShapeModel,
visibilityModel.diagonalGuidesVisibleProperty,
Expand Down

0 comments on commit c80ab3b

Please sign in to comment.