Only construct the tangible controller when running with query parame…

…ters, see #398
phetsims · Mar 21, 2023 · 7574829 · 7574829
1 parent 9da80ed
commit 7574829
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/js/quadrilateral/view/QuadrilateralNode.ts b/js/quadrilateral/view/QuadrilateralNode.ts
@@ -23,7 +23,6 @@ import PickRequired from '../../../../phet-core/js/types/PickRequired.js';
 import QuadrilateralDescriber from './QuadrilateralDescriber.js';
 import StrictOmit from '../../../../phet-core/js/types/StrictOmit.js';
 import Multilink from '../../../../axon/js/Multilink.js';
-import BooleanProperty from '../../../../axon/js/BooleanProperty.js';
 
 // constants
 const cornerAStringProperty = QuadrilateralStrings.a11y.cornerAStringProperty;

diff --git a/js/quadrilateral/view/QuadrilateralScreenView.ts b/js/quadrilateral/view/QuadrilateralScreenView.ts
@@ -51,8 +51,8 @@ export default class QuadrilateralScreenView extends ScreenView {
   private readonly quadrilateralDescriber: QuadrilateralDescriber;
   private readonly quadrilateralAlerter: QuadrilateralAlerter;
 
-  // REVIEW: Do we want prototype components going out in production code? Or move to a subclass? Or make nullable?
-  private readonly quadrilateralTangibleController: QuadrilateralTangibleController;
+  // Prototype components are only constructed and available when running with relevant query parameters.
+  private readonly quadrilateralTangibleController: QuadrilateralTangibleController | null = null;
   private readonly quadrilateralMediaPipe: QuadrilateralMediaPipe | null = null;
 
   public constructor( model: QuadrilateralModel, optionsModel: QuadrilateralOptionsModel, tandem: Tandem ) {
@@ -125,7 +125,9 @@ export default class QuadrilateralScreenView extends ScreenView {
     } );
 
     // tangible components
-    this.quadrilateralTangibleController = new QuadrilateralTangibleController( model );
+    if ( QuadrilateralQueryParameters.deviceConnection || MediaPipeQueryParameters.cameraInput === 'hands' ) {
+      this.quadrilateralTangibleController = new QuadrilateralTangibleController( model );
+    }
 
     // this parent only has children if relevant query params are provided, but is always created for easy layout
     const deviceConnectionParentNode = new VBox( {
@@ -134,13 +136,13 @@ export default class QuadrilateralScreenView extends ScreenView {
     } );
     if ( QuadrilateralQueryParameters.deviceConnection ) {
       deviceConnectionParentNode.children = [
-        new QuadrilateralTangibleControls( model.tangibleConnectionModel, this.quadrilateralTangibleController, tandem.createTandem( 'connectionControls' ) )
+        new QuadrilateralTangibleControls( model.tangibleConnectionModel, this.quadrilateralTangibleController!, tandem.createTandem( 'connectionControls' ) )
       ];
       deviceConnectionParentNode.top = gridNode.top;
       deviceConnectionParentNode.left = resetAllButton.left;
     }
     if ( MediaPipeQueryParameters.cameraInput === 'hands' ) {
-      this.quadrilateralMediaPipe = new QuadrilateralMediaPipe( model, this.quadrilateralTangibleController );
+      this.quadrilateralMediaPipe = new QuadrilateralMediaPipe( model, this.quadrilateralTangibleController! );
     }
 
     // voicing components