Skip to content

Commit

Permalink
Map is created in the constructor with values provided by the subtype…
Browse files Browse the repository at this point in the history
…, so it makes sense to use set - responding to review comment in #398
  • Loading branch information
jessegreenberg committed Mar 21, 2023
1 parent 6db7422 commit 51c8a18
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions js/quadrilateral/view/sound/EmphasisTracksSoundView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ export default class EmphasisTracksSoundView extends TracksSoundView {

// desired output levels for each sound (as requested by design after manually editing the gain)
// See https://github.com/phetsims/quadrilateral/issues/175#issuecomment-1400645437
// REVIEW: Many of the Maps in this sim are initialized with [[]], want to do that for this one too?
// - Sounds good!
this.indexToOutputLevelMap.set( 0, 0.75 );
this.indexToOutputLevelMap.set( 1, 0.75 );
this.indexToOutputLevelMap.set( 2, 1 );
Expand Down

0 comments on commit 51c8a18

Please sign in to comment.