Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance release testing #969

Closed
41 of 57 tasks
jonathanolson opened this issue Aug 5, 2023 · 8 comments
Closed
41 of 57 tasks

Maintenance release testing #969

jonathanolson opened this issue Aug 5, 2023 · 8 comments

Comments

@jonathanolson
Copy link
Contributor

jonathanolson commented Aug 5, 2023

For https://github.com/phetsims/special-ops/issues/244

We'll want to test the sim links, and:

  1. Briefly make sure the sim doesn't seem broken (10-15 seconds?)
  2. Add the stringTest query parameter present in https://github.com/phetsims/special-ops/issues/244#issue-1822496329, and see if it behaves as described in the issue (feel free to ask any questions in that issue).

beers-law-lab 1.7 (https://github.com/phetsims/special-ops/issues/244)

build-a-nucleus 1.0 (https://github.com/phetsims/special-ops/issues/244)

calculus-grapher 1.0 (https://github.com/phetsims/special-ops/issues/244)

circuit-construction-kit-dc 1.3 (https://github.com/phetsims/special-ops/issues/244)

circuit-construction-kit-dc-virtual-lab 1.3 (https://github.com/phetsims/special-ops/issues/244)

concentration 1.7 (https://github.com/phetsims/special-ops/issues/244)

density 1.1 (https://github.com/phetsims/special-ops/issues/244)

energy-skate-park 1.2 (https://github.com/phetsims/special-ops/issues/244)

friction 1.6 (https://github.com/phetsims/special-ops/issues/244)

geometric-optics 1.3 (https://github.com/phetsims/special-ops/issues/244)

geometric-optics-basics 1.3 (https://github.com/phetsims/special-ops/issues/244)

graphing-quadratics 1.3 (https://github.com/phetsims/special-ops/issues/244)

gravity-and-orbits 1.6 (https://github.com/phetsims/special-ops/issues/244)

greenhouse-effect 1.1 (https://github.com/phetsims/special-ops/issues/244)

mean-share-and-balance 1.0 (https://github.com/phetsims/special-ops/issues/244)

molecule-polarity 1.3 (https://github.com/phetsims/special-ops/issues/244)

molecule-shapes 1.6 (https://github.com/phetsims/special-ops/issues/244)

molecule-shapes-basics 1.6 (https://github.com/phetsims/special-ops/issues/244)

my-solar-system 1.2 (https://github.com/phetsims/special-ops/issues/244)

number-compare 1.0 (https://github.com/phetsims/special-ops/issues/244)

number-play 1.1 (https://github.com/phetsims/special-ops/issues/244)

ph-scale 1.6 (https://github.com/phetsims/special-ops/issues/244)

ph-scale-basics 1.6 (https://github.com/phetsims/special-ops/issues/244)

quadrilateral 1.1 (https://github.com/phetsims/special-ops/issues/244)

ratio-and-proportion 1.2 (https://github.com/phetsims/special-ops/issues/244)

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 8, 2023

A popup occurs with studio sims. If you launch the sim then the resulting sim has the popup.

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 8, 2023

Tests aside from studio have been completed.

@kathy-phet
Copy link

A popup occurs with studio sims. If you launch the sim then the resulting sim has the popup.

@KatieWoe - Can you expand on this and show a movie or screenshot? I don't know what you mean.

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 8, 2023

I discussed with @jonathanolson, but basically:

  1. Put the needed parameter at the end of a studio link.
  2. In studio, launch the sim (press the test button)
  3. The sim that is launched will have the pop-up (undesired behavior).

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 8, 2023

Example:
The sim in studio:
instudio
The sim after you press the test button:
pressedlaunch

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 9, 2023

I checked a published sim and #969 (comment) happens there too.

@KatieWoe
Copy link
Contributor

The fix is in #970, but it contains the studio error described in above comments. Though the pop-up is different in the dev test.
newcode

@jonathanolson
Copy link
Contributor Author

Published the existing changes/fixes. I'll open another QA issue once I have the studio issue resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants