Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2nd Dev test: Circuit Construction Kit: DC PhET-iO #774

Closed
11 of 13 tasks
samreid opened this issue Feb 11, 2022 · 3 comments
Closed
11 of 13 tasks

2nd Dev test: Circuit Construction Kit: DC PhET-iO #774

samreid opened this issue Feb 11, 2022 · 3 comments
Assignees
Labels
QA:dev-test Dev test before an RC

Comments

@samreid
Copy link
Member

samreid commented Feb 11, 2022

This will be the 2nd dev test. First one was completed in #772. The new URL for testing is:

https://phet-dev.colorado.edu/html/circuit-construction-kit-dc/1.3.0-dev.16/phet-io/

Addressed issues were reviewed in master. Some of the discovered issues from #772 were postponed to a future milestone.

Should I copy/paste the template from #772?

UPDATE: Here is the updated template from #772
UPDATE: This also includes some non-trivial changes from phetsims/tandem#254, which will be good to test.


@arouinfar, @kathy-phet, @KatieWoe, circuit-construction-kit-dc/1.3.0-dev.16/phet-io/ is ready for dev testing. We will
share this with a client and working toward full publication this quarter. Document issues in https://github.com/phetsims/circuit-construction-kit-common/issues and link to this
issue. I put it at the bottom of Active Tests in the QA pipeline, but please reprioritize as appropriate.

Assigning @kathy-phet and @KatieWoe for prioritization.

General Dev Test

What to Test

  • Click every single button.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Try to include browser version numbers
  • If there is a console available, check for errors and include them in the Problem Description.
  • Run through the string tests on at least one platform, especially if it is about to go to rc.
  • Check the Game Up harness on one platform.

Focus and Special Instructions

This test is mainly for PhET-iO. Most of the testing can be done there, but I recommend at least spot checks to make
sure there are no regressions or unexpected behaviors in the PhET-brand version.

General Dev Test Platforms

Please include (non-screen reader) a11y testing in these records if applicable.

  • Latest macOS, Safari (Time = .75 hrs)
  • Windows 10, Chrome (Time = 1hr)
  • Windows 10, Firefox (Time = 2.5)
  • Latest iOS, Safari (Time = .75hrs)
  • Windows 11, Chrome (Time = .5)

Light testing, or optionally skip if time crunch:

  • Latest macOS, Chrome (Time = )
  • Latest Chrome OS, Chrome (Time = .5)

Link(s)


PhET-iO Dev Test

What to Test

  • Make sure that public files do not have password protection. Use a private browser for this.
  • Make sure that private files do have password protection. Use a private browser for this.
  • Make sure standalone sim is working properly.
  • Make sure the wrapper index is working properly.
  • Make sure each wrapper is working properly.
  • Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
  • For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
    sure the simulation loads without crashing or throwing errors.

General Dev Test Platforms

  • Latest macOS, Safari (Time = 3hrs)
  • Latest iOS, Safari (Time = 1.5hrs)
  • Windows 10, Chrome (Time = 4hrs)
  • Windows 10/11, Firefox (Time = 2)
  • Windows 11, Chrome (Time = 2.5)
  • Latest Chrome OS, Chrome (Time = 2)

Focus and Special Instructions

This is an initial release for PhET-iO support in Circuit Construction Kit. All major PhET-iO features should be working.
The studio tree should seem reasonable. Some issues we addressed for this milestone are listed in:
https://github.com/phetsims/circuit-construction-kit-common/milestone/4

Some issues we moved to a later milestone are:
https://github.com/phetsims/circuit-construction-kit-common/milestone/5

Link(s)


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@KatieWoe
Copy link
Contributor

@samreid Yes, please use either that template or a new one from the repo.

@samreid samreid added the QA:dev-test Dev test before an RC label Feb 11, 2022
@samreid samreid assigned kathy-phet and unassigned samreid Feb 11, 2022
@KatieWoe
Copy link
Contributor

QA is done

@KatieWoe KatieWoe assigned samreid and unassigned KatieWoe Feb 17, 2022
@samreid
Copy link
Member Author

samreid commented Feb 18, 2022

Thanks! I marked the open issues for the DC PhET-iO milestone. Closing.

@samreid samreid closed this as completed Feb 18, 2022
@KatieWoe KatieWoe moved this to Done in QA Pipeline Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:dev-test Dev test before an RC
Projects
Status: Done
Development

No branches or pull requests

3 participants