Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel's Next/Previous buttons do not stay disabled in Studio #844

Closed
Nancy-Salpepi opened this issue Feb 4, 2022 · 4 comments
Closed
Assignees
Labels

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
12.0.1

Browser
Safari

Problem description
For phetsims/qa#772 in the Studio Wrapper:

If the previous button and next button are disabled, they will be enabled when the sim is launched.
This happens on both screens.

Steps to reproduce

  1. In studio, navigate to the second page of the carousel on either screen
  2. Disable the previous button (view.circuitElementToolbox.carousel.previousButton.enabledProperty)
  3. Disable the next button (view.circuitElementToolbox.carousel.nextButton.enabledProperty)
  4. Launch the sim

Visuals
carouselbuttons

@arouinfar
Copy link
Contributor

Thanks @Nancy-Salpepi. I think the solution here is that carousel.nextButton.enabledProperty and carousel.previousButton.enabledProperty should be phetioReadOnly: true. However, that should be handled in a separate issue for the PhET-iO design patterns for carousel. Self-assigning to open an issue in sun.

@arouinfar
Copy link
Contributor

Design issue for carousel linked above, closing.

@KatieWoe
Copy link
Contributor

This has not been done in the newest dev. Reopening for phetsims/qa#774
notdone

@arouinfar
Copy link
Contributor

Thanks @KatieWoe this issue will be addressed in phetsims/sun#736 where the button's enabledProperty will be made read-only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants