Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subdivide velocityControlPanel on intro screen #259

Closed
arouinfar opened this issue Feb 25, 2021 · 2 comments
Closed

subdivide velocityControlPanel on intro screen #259

arouinfar opened this issue Feb 25, 2021 · 2 comments

Comments

@arouinfar
Copy link
Contributor

For #244

On the Intro Screen, the vectorsControlPanel could benefit from some subdivision, somewhat similar to what we did with the airReistanceControl in #225.

image

Here's a proposed tree structure:

vectorsControlPanel
    visibleProperty
  - accelerationVectors
        visibleProperty
      - titleNode 
             visibleProperty
             textProperty
        (checkboxes & their children)
  - velocityVectors
        visibleProperty
      - titleNode 
             visibleProperty
             textProperty
        (checkboxes & their children)
  • Create containers for velocity vectors and acceleration vectors
  • Give each container a visibleProperty so all velocity-related or acceleration-related content can be hidden in one go
  • Instrument the titles and add them to their respective containers.
  • Make vector icons listen to the visibility of the corresponding label, so hiding the label also hides the icon.
@zepumph
Copy link
Member

zepumph commented Jul 26, 2021

That should do it, please review. Please note, that this panel is custom only for the intro screen, so any other screen will not pick up these changes. Let me know if there is more to do.

@arouinfar
Copy link
Contributor Author

Looks good in master, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants