Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add titleNode to labScreen.view.initialValuesPanel #256

Closed
arouinfar opened this issue Feb 25, 2021 · 2 comments
Closed

Add titleNode to labScreen.view.initialValuesPanel #256

arouinfar opened this issue Feb 25, 2021 · 2 comments

Comments

@arouinfar
Copy link
Contributor

For #244

This is labScreen.view.initialValuesPanel
Screen Shot 2021-02-24 at 5 56 57 PM

We'd like to instrument the "Initial Values" title and give it a visibleProperty and textProperty. The tree structure would look like this:

initialValuesPanel
    visibleProperty
  + angleReadout
  + heightReadout
  - titleNode
       textProperty
       visibleProperty
  + velocityReadout
@zepumph
Copy link
Member

zepumph commented Jul 26, 2021

It seems like most of this happened two days after opening this issue in b703492, as part of #219, but I don't see a paper trail on that structure over there. Added a titleNode, but that is all.

Anyways. . . .

Please review in master, the readout textProperties are phetioReadOnly: true, is that correct?

@arouinfar
Copy link
Contributor Author

The new titleNode looks good in master.

the readout textProperties are phetioReadOnly: true, is that correct?

Yes, that's correct. The readout text should match the actual data in the sim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants