-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to independently disable cannon height and angle adjustments #248
Comments
I actually though it was easier to instrument on the listeners themselves, since for the height one the listener was added to many Nodes. Having the flexibility to disable based on the Node and/or listener is really nice. Please experiment with PhET-iO elements like these, and let me know what you think: height: rotation: |
I also fixed the cursor, so that it can come from the input listener instead of each Node that the single listener is added to. This further simplifies the file. Now, disabled input listeners will show the default cursor. |
It has been done. |
Looks good, thanks! |
For #244
Related issues
phetsims/scenery#1041
phetsims/scenery#1116
phetsims/bending-light#397
The cannon can be adjusted in two ways:
Clients should be able to independently disable these interactions (whether by pickableProperty or its successor).
The text was updated successfully, but these errors were encountered: