Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change several properties to readOnly: false #247

Closed
4 tasks done
arouinfar opened this issue Feb 23, 2021 · 3 comments
Closed
4 tasks done

Change several properties to readOnly: false #247

arouinfar opened this issue Feb 23, 2021 · 3 comments

Comments

@arouinfar
Copy link
Contributor

arouinfar commented Feb 23, 2021

For #244

This is a reversal of a request in #219 (sorry @zepumph!)

Several parameters are constant on early screens but adjustable on the Lab screen. We originally requested that these properties be made read-only, but this would prevent a client from adjusting the values using an API.

While @zepumph has mentioned that it's possible to make the properties ready only on a sub-set of screens, we thought it would be best to make these readOnly: false on all screens. This will allow the client greater control of customization.

@zepumph please make the following readOnly: false on ALL screens.

  • model.gravityProperty
  • model.projectileDiameterProperty
  • model.projectileDragCoefficientProperty
  • model.projectileMassProperty
@arouinfar
Copy link
Contributor Author

arouinfar commented Feb 23, 2021

@zepumph not sure if making these readOnly: false will automatically add a slider to the studio interface or not. If so, please disable it. We don't want to add a slider to studio to adjust these properties.

@zepumph
Copy link
Member

zepumph commented Jul 26, 2021

Done. Note that I took out the readOnly, but added in phetioStudioControl: false, so there is still no slider to adjust in studio.

image

Anything else here?

@arouinfar
Copy link
Contributor Author

Thanks @zepumph! Looks good in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants