Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PhetColorScheme.VELOCITY and PhetColorScheme.ACCELERATION #233

Closed
arouinfar opened this issue Sep 29, 2020 · 1 comment
Closed

Use PhetColorScheme.VELOCITY and PhetColorScheme.ACCELERATION #233

arouinfar opened this issue Sep 29, 2020 · 1 comment
Assignees

Comments

@arouinfar
Copy link
Contributor

In phetsims/scenery-phet#621 we modernized the colors used for velocity and acceleration.

This sim currently uses similar colors for the velocity and acceleration fills, but should be updated to use PhetColorScheme.
https://github.com/phetsims/projectile-motion/blob/master/js/common/ProjectileMotionConstants.js#L57-L58

Assigning @zepumph since this change should be included in the next release and he's currently serving as interim responsible-dev while iO work is ongoing.

@zepumph
Copy link
Member

zepumph commented Apr 21, 2021

Sounds good. I used the constants (always love a constant!), but the values were already the same, so there is no change in output. Closing.

@zepumph zepumph closed this as completed Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants