Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove TrajectoryIO.ioTypeSchema and prefer forwarding to the IO Type #231

Closed
zepumph opened this issue Sep 2, 2020 · 2 comments
Closed

remove TrajectoryIO.ioTypeSchema and prefer forwarding to the IO Type #231

zepumph opened this issue Sep 2, 2020 · 2 comments
Assignees
@zepumph
Labels
dev:code-review

Comments

@zepumph
Copy link
Member

zepumph commented Sep 2, 2020

From https://github.com/phetsims/phet-io/issues/1646, this is not the pattern we are using for IO Type state methods.
@zepumph zepumph self-assigned this Sep 2, 2020
@zepumph
Copy link
Member Author

zepumph commented Apr 21, 2021

The above is a bug fix for validValues in studio for phetioIDs like projectileMotion.introScreen.model.selectedProjectileObjectTypeProperty. The for id included the object toString like [ Object ]

zepumph added a commit that referenced this issue Apr 21, 2021
@zepumph
convert from "ioTypeSchema" pattern to IOType.fromCoreType, #231
bc33f5f
@zepumph
Copy link
Member Author

zepumph commented Apr 21, 2021

Converted to the better schema above.

@zepumph zepumph closed this as completed Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph