Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Tracer to DataProbe #222

Closed
zepumph opened this issue Feb 27, 2020 · 2 comments
Closed

Rename Tracer to DataProbe #222

zepumph opened this issue Feb 27, 2020 · 2 comments
Assignees
@arouinfar
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Feb 27, 2020

From #219, @arouinfar had a review comment like:

The probe that reads data from the points along the trajectory is simply called the tracer, but a more informative name would be something like dataProbe which is a name we've decided to use in Natural Selection. Would it take a lot of restructuring to call this a dataProbe?

I'll get on it!
@zepumph zepumph self-assigned this Feb 27, 2020
@arouinfar arouinfar mentioned this issue Feb 27, 2020
Closed
22 tasks
zepumph added a commit that referenced this issue Feb 27, 2020
@zepumph
rename "tracer" to "dataProbe" #222
1f1c17c
@zepumph
Copy link
Member Author

zepumph commented Feb 27, 2020

Implemented above. Please review.

@zepumph zepumph assigned arouinfar and unassigned zepumph Feb 27, 2020
@arouinfar
Copy link
Contributor

Looks great, thanks @zepumph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zepumph @arouinfar