Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert DownUpListeners to FireListeners #209

Closed
zepumph opened this issue Oct 11, 2019 · 2 comments
Closed

Convert DownUpListeners to FireListeners #209

zepumph opened this issue Oct 11, 2019 · 2 comments
Assignees
@zepumph
Labels
dev:phet-io status:blocks-sim-publication

Comments

@zepumph
Copy link
Member

zepumph commented Oct 11, 2019

No description provided.

@zepumph zepumph self-assigned this Oct 11, 2019
@zepumph zepumph transferred this issue from phetsims/scenery-phet Nov 19, 2019
zepumph added a commit that referenced this issue Nov 22, 2019
@zepumph
convert DownUpListener to FireListener, #209
9fc36a1
@zepumph zepumph changed the title Convert DownUpListeners to PressListeners Convert DownUpListeners to FireListeners Nov 22, 2019
@zepumph zepumph mentioned this issue Nov 22, 2019
Open
@zepumph
Copy link
Member Author

zepumph commented Nov 22, 2019

I don't want to publish PM with a DownUpListener in it until we have discussed phetsims/scenery#1021 more. DownUpListener has quite a bit less phet-io instrumentation than PressListeners, which run on emitters like other phet-io events.

@zepumph zepumph mentioned this issue Nov 23, 2019
Closed
zepumph added a commit that referenced this issue Jan 3, 2020
@zepumph
convert downUpListener to FireListener, phetsims/scenery#1021 #209
e291302
@zepumph
Copy link
Member Author

zepumph commented Jan 3, 2020

Over in phetsims/scenery#1021 @jonathanolson proposed a fix, and it worked. The conversion was done in the above commit (and phet-io instrumented). Closing

@zepumph zepumph closed this as completed Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
dev:phet-io status:blocks-sim-publication
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph