Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT: this.projectileChoiceComboBox.hideListFromClick is not a function #170

Closed
jbphet opened this issue Jan 16, 2019 · 2 comments
Closed
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Jan 16, 2019

This sim is failing continuous test (CT) at the moment. It appears that this is due to the removal of the method hideListFromClick from the combo box. It looks like this is due to some refactoring work that was being done by @pixelzoom. That method is no longer present in ComboBox, but is mentioned in some comments that would seem to imply that the method should be there. They look like this (from ComboBox.js):

    //TODO sun#314 if "Most often should be called from hideListFromClick" then why is this called 6 times from other places, which hideListFromClick is called once?
    /**
     * Hides the combo box list. Most often should be called from hideListFromClick
     * @private
     */

@pixelzoom - can you take a look?

@pixelzoom
Copy link
Contributor

pixelzoom commented Jan 16, 2019

hideListFromClick was apparently added to pop the list down when the browser is window is resized, so that the list doesn't get disconnected from the combo box. At bit of a hack, but see phetsims/sun#366. We should now be able to simply call hideList. I'll investigate.

@pixelzoom
Copy link
Contributor

Fixed in the above commit. I confirmed that it's sufficient to call ComboBox hideList, and I tested that it properly pops down the list when the browser window is resized. Also tested projectile-motion with ?ea&fuzz.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants