clean-up and document PM use of useParentOffset, phetsims/scenery#1014

#183
phetsims · Dec 13, 2019 · ee20b1e · ee20b1e
1 parent 868b0d3
commit ee20b1e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/js/common/view/ToolboxPanel.js b/js/common/view/ToolboxPanel.js
@@ -82,7 +82,11 @@ define( require => {
     // When pressed, forwards dragging to the actual tracer Node
     tracerIconNode.addInputListener( DragListener.createForwardingListener( event => {
       tracer.isActiveProperty.set( true );
-      tracer.positionProperty.value = transformProperty.value.viewToModelPosition( this.globalToParentPoint( event.pointer.point ) );
+
+      // offset when pulling out of the toolbox so that the pointer isn't on top of the tool. Convert to parent point
+      // because the TracerNode's DragListener is applying its pointer offset in the parent coordinate frame (see https://github.com/phetsims/scenery/issues/1014)
+      const parentPoint = this.globalToParentPoint( event.pointer.point.plusXY( -200, 0 ) );
+      tracer.positionProperty.value = transformProperty.value.viewToModelPosition( parentPoint );
       tracerNode.dragListener.press( event, tracerNode );
     }, { allowTouchSnag: true } ) );
 

diff --git a/js/common/view/TracerNode.js b/js/common/view/TracerNode.js
@@ -156,7 +156,6 @@ define( require => {
       locationProperty: tracer.positionProperty,
       transform: transformProperty.get(),
       dragBoundsProperty: dragBoundsProperty,
-      offsetLocation: () => DRAG_OFFSET,
       useParentOffset: true,
       start: () => self.isUserControlledProperty.set( true ),
       end: () => self.isUserControlledProperty.set( false ),