-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODAP Missing Projectile Data #337
Comments
Can be very bad in phetsims/qa#1099 when sample sizes are large. |
Brainstorming a plan:
|
This has been fixed in the commit. Marking for review during RC 1. |
When I was testing the wrapper from another issue, I launched several projectiles in PSD+CODAP in this way:
I noticed not all the data came through. You can see in the screenshot that are a zero samples of size 40 in the CODAP table (look at the 2nd hierarchical variable), even though you can see on the field sign that there were 31 samples launched. The histogram also shows this data. I launched:
For a total of 3166 projectile. At the top of the table it says there are 996 cases, meaning there are 2170 cases missing. I tried it again and was able to reproduce. Then I tried it with each sample size, but waited until all the projectiles had been populated in the table prior to launching more with a different sample size.
|
I will note that for the samples CODAP did record, they had the correct corresponding number in them per sample size. |
Good find @catherinecarter. This will be addressed in #349 when the queueing system designed for #338 is applied to the PSD CODAP wrapper. |
This looks OK to me with mac + chrome/safari in rc.1 but will keep open until other devices (Chromebook) and PSD are tested. |
I managed to get up to 7500 cases. After that nothing was recorded at all, so it seems like there is a max. Before that a lag started being noticeable but everything was being recorded. Win 11 Chrome |
Device
Dell
OS
Win 11
Browser
Chrome
Problem Description
For phetsims/qa#1096
When a large number of projectiles have been launched, it is possible that some of them won't be picked up by CODAP. This does not happen every time, and so may be related to performance/speed/memory.
Steps to Reproduce
Visuals
The text was updated successfully, but these errors were encountered: