Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted parameter #323

Closed
KatieWoe opened this issue May 2, 2024 · 2 comments
Closed

Unwanted parameter #323

KatieWoe opened this issue May 2, 2024 · 2 comments
Assignees
Labels
type:bug Something isn't working

Comments

@KatieWoe
Copy link

KatieWoe commented May 2, 2024

Test device
Samsung
Operating System
Win 11
Browser
Chrome
Problem description
For phetsims/qa#1083
histogramBins=totalBins should not be available in PDL, but the parameter works and changes the bin strategy. projectileTypeAffectsSpeed and showStandardError also do not apply, but I can't tell if they are present because if they are they make no noticeable changes on the sim.

Visuals
works

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Projectile Sampling Distributions‬
URL: https://phet-dev.colorado.edu/html/projectile-sampling-distributions/1.0.0-rc.7/phet/projectile-sampling-distributions_all_phet.html
Version: 1.0.0-rc.7 2024-05-02 19:37:47 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36
Language: en-US
Window: 1536x695
Pixel Ratio: 1.25/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 31 uniform: 4096
Texture: size: 8192 imageUnits: 32 (vertex: 32, combined: 64)
Max viewport: 8192x8192
OES_texture_float: true
Dependencies JSON: {}

@KatieWoe KatieWoe added the type:bug Something isn't working label May 2, 2024
matthew-blackman added a commit that referenced this issue May 2, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…see #323
samreid pushed a commit that referenced this issue May 2, 2024
@matthew-blackman
Copy link
Contributor

This has been fixed in the commit. @samreid and I agreed that it if a user were to add histogramBins=totalBins to the PSD sim, we want to display the 'Invalid Query Parameters' dialog. This is not the case with projectileTypeAffectsSpeed and showStandardError, since these have no impact on the PSD sim.

samreid added a commit that referenced this issue May 2, 2024
samreid added a commit to phetsims/projectile-sampling-distributions that referenced this issue May 2, 2024
samreid added a commit to phetsims/projectile-sampling-distributions that referenced this issue May 2, 2024
@KatieWoe
Copy link
Author

KatieWoe commented May 2, 2024

Looks good to me

@KatieWoe KatieWoe closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants