Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projectile Sampling Distributions: Remove bin width of 10 #317

Closed
Tracked by #1081
matthew-blackman opened this issue Apr 24, 2024 · 2 comments
Closed
Tracked by #1081

Projectile Sampling Distributions: Remove bin width of 10 #317

matthew-blackman opened this issue Apr 24, 2024 · 2 comments
Assignees
@matthew-blackman
Labels
status:ready-for-review status:ready-to-cherry-pick

Comments

@matthew-blackman
Copy link
Contributor

Discussing this with @catherinecarter and Kelly, we agreed that the bin width of 10 is not useful in the PSD sim. The means are less spread out than the raw data, so the bin widths of 10 is not necessary. Let's remove this option from PSD.
@matthew-blackman matthew-blackman self-assigned this Apr 24, 2024
samreid added a commit that referenced this issue Apr 24, 2024
@samreid
For projectile-sampling-distributions: remove bin width of 10, set de…
b81909b 
…fault bin width to 0.5, remove total number of bins, see #317 and #318 and #315
samreid added a commit that referenced this issue Apr 24, 2024
@samreid
For projectile-sampling-distributions: remove bin width of 10, set de…
107ba25 
…fault bin width to 0.5, remove total number of bins, see #317 and #318 and #315

(cherry picked from commit b81909b)
@matthew-blackman
Copy link
Contributor Author

Please close after verifying.

@matthew-blackman matthew-blackman mentioned this issue Apr 29, 2024
Closed
13 tasks
@KatieWoe
Copy link

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthew-blackman matthew-blackman

Labels
status:ready-for-review status:ready-to-cherry-pick
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KatieWoe @matthew-blackman