-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen identifiers should not include the word 'screen' #314
Comments
This has been implemented in the commit. Marking to cherry-pick. |
The above commit uses the screen identifier values instead of tandem names, as well as adds support for the the screen identifier variable to the CODAP wrapper. Marking ready to cherry-pick. |
Please close after verifying. |
@KatieWoe - I believe this issue is referring to what string will be passed into CODAP as the title of a column heading. I don't believe this is meant to refer to the PhET-iO ID in studio. |
In that case, what should I check in rc.2? |
Oh shoot! I meant the contents of the column not the column heading. So what to look for... I believe it would be to make sure that if you launch projectiles on one screen, let's just say launcher 4 on the Variability Screen, and then you launch the same launcher from a different screen, say launcher 4 on the Measures Screen, then the contents of the "screen" column in the table would say, "Variability" and "Measures," respectively. Does that make sense? The purpose is to delineate which screen the launches came from, in case anyone wanted to recreate the histogram per screen without combining data in an unwanted way. |
We haven't been given anything to do with codap in these tests. I was told that would be next release. I don't know how to check this table. |
Gotcha. We will await instructions from @matthew-blackman and @samreid. I don't have the link to take a look myself. Thanks, Katie! |
Discussed on zoom. This was checked by examining the state using code from the examples doc. Things look ok, closing. |
Discussing this with @catherinecarter, we agreed that makes the identifiers too long. Let's use
'variability', 'sources', 'measures', 'sampling'
instead of'variabilityScreen', 'sourcesScreen', 'measuresScreen', 'samplingScreen'
.The text was updated successfully, but these errors were encountered: