Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample appears when stopping continuous sampling #295

Closed
Tracked by #1079
matthew-blackman opened this issue Apr 17, 2024 · 5 comments
Closed
Tracked by #1079

Sample appears when stopping continuous sampling #295

matthew-blackman opened this issue Apr 17, 2024 · 5 comments
Labels
status:ready-for-review status:ready-to-cherry-pick type:bug Something isn't working

Comments

@matthew-blackman
Copy link
Contributor

To trigger this behavior:

  1. Start continuous sampling
  2. Pause the sim
  3. Press the clear button
  4. Press the button to stop continuous sampling (while still paused)

The sim's current behavior is that it will erroneously create a sample on step 4. This sample should not appear. All other behavior should stay the same. Let's fix it!
@matthew-blackman matthew-blackman added the type:bug Something isn't working label Apr 17, 2024
matthew-blackman added a commit that referenced this issue Apr 17, 2024
@matthew-blackman
Add guard for creating sample in idle phase - see #295
6722201
@matthew-blackman
Copy link
Contributor Author

This is fixed in the commit. @KatieWoe and @Nancy-Salpepi please confirm. @samreid and I also wanted to bring attention here for further testing, as we feel that additional edge cases in this area are likely.

@KatieWoe
Copy link

Looks ok on main. We'll keep an eye out for similar issues in the next test.

@Nancy-Salpepi
Copy link

Looks good to me too.

matthew-blackman added a commit that referenced this issue Apr 22, 2024
@matthew-blackman
Add guard for creating sample in idle phase - see #295
245e19e 
(cherry picked from commit 6722201)
@matthew-blackman
Copy link
Contributor Author

Please close after verifying.

@matthew-blackman matthew-blackman mentioned this issue Apr 26, 2024
Closed
28 tasks
@KatieWoe
Copy link

Looks good in rc.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready-for-review status:ready-to-cherry-pick type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samreid @KatieWoe @Nancy-Salpepi @matthew-blackman