Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sound when auto-generating data using hotkeys #293

Closed
Tracked by #1079
Nancy-Salpepi opened this issue Apr 15, 2024 · 3 comments
Closed
Tracked by #1079

Add sound when auto-generating data using hotkeys #293

Nancy-Salpepi opened this issue Apr 15, 2024 · 3 comments
Labels
design:sound status:ready-for-review status:ready-to-cherry-pick type:suggestion

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
14.4.1

Browser
Chrome

Problem description
For phetsims/qa#1068, with Auto-Generate Data on, there is no sound when I use the launch shortcut option + L.

Steps to reproduce

  1. In preferences, turn on Auto-Generate Data
  2. On any screen, press option + L
samreid added a commit that referenced this issue Apr 15, 2024
@samreid
Add sound when auto-generating data using hotkeys, see #293
785f1a4
@samreid samreid removed their assignment Apr 15, 2024
@matthew-blackman matthew-blackman removed their assignment Apr 16, 2024
@matthew-blackman
Copy link
Contributor

Nice work! This is ready to cherry-pick.

matthew-blackman pushed a commit that referenced this issue Apr 22, 2024
@samreid @matthew-blackman
Add sound when auto-generating data using hotkeys, see #293
e55fe4e 
(cherry picked from commit 785f1a4)
@matthew-blackman
Copy link
Contributor

Please close after verifying.

@matthew-blackman matthew-blackman mentioned this issue Apr 26, 2024
Closed
28 tasks
@KatieWoe
Copy link

Looks good in rc.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design:sound status:ready-for-review status:ready-to-cherry-pick type:suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samreid @KatieWoe @Nancy-Salpepi @matthew-blackman