Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launching doesn't resume at correct sample # if on an earlier sample #287

Closed
Tracked by #1079
Nancy-Salpepi opened this issue Apr 11, 2024 · 4 comments
Closed
Tracked by #1079

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
14.4.1

Browser
Chrome

Problem description
For phetsims/qa#1068, on the Sampling Screen:
If I am on an earlier sample, ex. 2 or 30, pressing the launch button again will not resume sampling at 31. Instead it will resume at sample 3 of 30.

Steps to reproduce

  1. On the Sampling screen, select Continuous mode and then press the Launch button to produce a bunch of samples
  2. Press the Stop button
  3. Use the decrement button to select an earlier sample
  4. Press the Launch button again.

Visuals

SamplingScreenBug.mp4
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Projectile Data Lab‬ URL: https://phet-dev.colorado.edu/html/projectile-data-lab/1.0.0-rc.1/phet/projectile-data-lab_all_phet.html Version: 1.0.0-rc.1 2024-04-09 18:41:49 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36 Language: en-US Window: 1308x720 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@matthew-blackman
Copy link
Contributor

Good find @Nancy-Salpepi! This ended up being more straightforward to fix than I initially thought. Can you confirm that it's fixed on main?

@Nancy-Salpepi
Copy link
Author

Looks good on main!

@matthew-blackman
Copy link
Contributor

Please close after verifying.

@KatieWoe
Copy link

Looks good in rc.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants