Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSMField resets field owned by superclass Field. #221

Closed
pixelzoom opened this issue Mar 3, 2024 · 1 comment
Closed

VSMField resets field owned by superclass Field. #221

pixelzoom opened this issue Mar 3, 2024 · 1 comment
Assignees

Comments

@pixelzoom
Copy link
Contributor

For code review #32 ...

VSMField is currently resetting angleStabilizerProperty, which is owned by superclass Field:

  public override reset(): void {
    super.reset();

    this.angleStabilizerProperty.reset();
    this.continuousLaunchTimer.reset();
  }

Why is angleStabilizerProperty not being reset in Field reset? If there a good reason, document. Otherwise move it.

@samreid
Copy link
Member

samreid commented Mar 4, 2024

Good recommendation. @matthew-blackman and I moved it to the parent class and it seems better. Closing.

@samreid samreid closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants