We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For code review #32 ...
VSMField is currently resetting angleStabilizerProperty, which is owned by superclass Field:
angleStabilizerProperty
public override reset(): void { super.reset(); this.angleStabilizerProperty.reset(); this.continuousLaunchTimer.reset(); }
Why is angleStabilizerProperty not being reset in Field reset? If there a good reason, document. Otherwise move it.
reset
The text was updated successfully, but these errors were encountered:
Move angleStabilizerProperty reset to the parent class, see #221
2f9451c
Good recommendation. @matthew-blackman and I moved it to the parent class and it seems better. Closing.
Sorry, something went wrong.
samreid
matthew-blackman
No branches or pull requests
For code review #32 ...
VSMField is currently resetting
angleStabilizerProperty
, which is owned by superclass Field:Why is
angleStabilizerProperty
not being reset in Fieldreset
? If there a good reason, document. Otherwise move it.The text was updated successfully, but these errors were encountered: