You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The only difference I see in keyboard help for the 4 screens is that the Sampling screen does not have the "Select a field" shortcut. So I expected to see 1 implementation of keyboard help where that shortcut is optional.
Instead, I see an overly complicated implementation with 7 classes. And the line that I expected to see optionally added is instead duplicated:
@matthew-blackman@samreid ready for your review. As we discussed, PDLKeyboardHelpNodeOptions was implemented so that interval tool shortcuts can be included for the Measures screen.
For code review #32 ...
The only difference I see in keyboard help for the 4 screens is that the Sampling screen does not have the "Select a field" shortcut. So I expected to see 1 implementation of keyboard help where that shortcut is optional.
Instead, I see an overly complicated implementation with 7 classes. And the line that I expected to see optionally added is instead duplicated:
@samreid @matthew-blackman and I discussed this, and I will push a simplified implementation for their review.
The text was updated successfully, but these errors were encountered: