Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the implementation of keyboard help. #210

Closed
pixelzoom opened this issue Feb 29, 2024 · 2 comments
Closed

Simplify the implementation of keyboard help. #210

pixelzoom opened this issue Feb 29, 2024 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 29, 2024

For code review #32 ...

The only difference I see in keyboard help for the 4 screens is that the Sampling screen does not have the "Select a field" shortcut. So I expected to see 1 implementation of keyboard help where that shortcut is optional.

Instead, I see an overly complicated implementation with 7 classes. And the line that I expected to see optionally added is instead duplicated:

    const row = KeyboardHelpSectionRow.createKeysRow( [ TextKeyNode.altOrOption(), LetterKeyNode.l() ], ProjectileDataLabStrings.pressTheLaunchButtonStringProperty );

@samreid @matthew-blackman and I discussed this, and I will push a simplified implementation for their review.

@pixelzoom pixelzoom self-assigned this Feb 29, 2024
pixelzoom added a commit that referenced this issue Feb 29, 2024
pixelzoom added a commit that referenced this issue Feb 29, 2024
@pixelzoom
Copy link
Contributor Author

@matthew-blackman @samreid ready for your review. As we discussed, PDLKeyboardHelpNodeOptions was implemented so that interval tool shortcuts can be included for the Measures screen.

@samreid
Copy link
Member

samreid commented Feb 29, 2024

I confirmed this is working well and the implementation is much simpler, thanks @pixelzoom. Closing.

@samreid samreid closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants