-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review eslintConfig in package.json #200
Comments
package.json eslintConfig currently looks like this: "eslintConfig": {
"extends": "../chipper/eslint/sim_eslintrc.js",
"overrides": [
{
"files": [
"**/*.ts"
],
"rules": {
"@typescript-eslint/ban-ts-comment": [
"error",
{
"ts-expect-error": true,
"ts-ignore": true,
"ts-check": true,
"ts-nocheck": true
}
],
"no-object-spread-on-non-literals": "error",
"additional-bad-text": [
"error",
{
"forbiddenTextObjects": [
"dispose"
]
}
],
"author-annotation": "error"
}
}
]
} What do you recommend we change? |
(oops, accidentally pressed close. Reopened). |
I said it should be reviewed and cleaned up. For example, |
Thanks! I checked each entry and saw that the two you mentioned are unnecessary. The other ones seem necessary. So I removed the redundant ones. Closing. |
Related to code review #32 ...
From the CRC:
eslintConfig
looks like it needs some cleanup, sometime before the sim is published.The text was updated successfully, but these errors were encountered: