You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a number of files with "VSM" and "SM" prefixes. Non-standard prefixes should be documented somewhere, implemenation-notes.md looks like the intended place, but it's incomplete -- it identifies "VSM" but not "SM". I'm not sure if there are other such prefixes, because I'm partway through the review.
If you decide to keep common-vsm and common-sm in #197, you might also say something about them in implemenation-notes.md (correspondence to "VSM" and "SM", what value they are providing, etc.)
The text was updated successfully, but these errors were encountered:
Related to code review #32 ...
From the CRC:
There are a number of files with "VSM" and "SM" prefixes. Non-standard prefixes should be documented somewhere, implemenation-notes.md looks like the intended place, but it's incomplete -- it identifies "VSM" but not "SM". I'm not sure if there are other such prefixes, because I'm partway through the review.
If you decide to keep common-vsm and common-sm in #197, you might also say something about them in implemenation-notes.md (correspondence to "VSM" and "SM", what value they are providing, etc.)
The text was updated successfully, but these errors were encountered: