Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation-notes.md, Does it provide an overview that will be useful to future maintainers? #185

Closed
Tracked by #183
samreid opened this issue Feb 26, 2024 · 2 comments
Closed
Tracked by #183

implementation-notes.md, Does it provide an overview that will be useful to future maintainers? #185

samreid opened this issue Feb 26, 2024 · 2 comments

Comments

@samreid
Copy link
Member

samreid commented Feb 26, 2024 •
edited by pixelzoom
Loading

https://github.com/phetsims/projectile-data-lab/blob/main/doc/implementation-notes.md
@samreid samreid mentioned this issue Feb 26, 2024
Closed
98 tasks
@samreid samreid changed the title implementation-notes.md, see {{GITHUB_ISSUE_LINK}}. Familiarize yourself with the implementation by reading implementation-notes.md, Does it provide an overview that will be useful to future maintainers? Feb 26, 2024
@pixelzoom pixelzoom mentioned this issue Feb 27, 2024
Closed
pixelzoom added a commit that referenced this issue Feb 27, 2024
@pixelzoom
add sim name to title #185
c1b22ed
pixelzoom added a commit that referenced this issue Feb 27, 2024
@pixelzoom
move Sonification to its own section #185
4e5cdd0
pixelzoom added a commit that referenced this issue Feb 27, 2024
@pixelzoom
#185
a161fd8
pixelzoom added a commit that referenced this issue Feb 27, 2024
@pixelzoom
format code example #185
648e13e
@pixelzoom
Copy link
Contributor

I reviewed implementation-notes.md for code review #32. It seems reasonable to me, and I made a couple of minor changes in the commits linked directely above this comment.

@samreid
Copy link
Member Author

samreid commented Feb 27, 2024

Excellent, thanks! I'll close this one and leave #184 for @matthew-blackman to sign off. Closing.

@samreid samreid closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @pixelzoom