You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
function LabPlayPanel( model, ballModeProperty, isBallCapReachedProperty, options )
Call site is:
var playPanel = new LabPlayPanel( model, model.ballModeProperty, model.isBallCapReachedProperty, {...} )
So the ballModeProperty and isBallCapReachedProperty parameters are redundant. And they are in fact used inconsistently in LabPlayPanel's constructor, sometimes using model, sometimes using the redundant parameters. E.g.:
Constructor signature is:
function LabPlayPanel( model, ballModeProperty, isBallCapReachedProperty, options )
Call site is:
var playPanel = new LabPlayPanel( model, model.ballModeProperty, model.isBallCapReachedProperty, {...} )
So the
ballModeProperty
andisBallCapReachedProperty
parameters are redundant. And they are in fact used inconsistently in LabPlayPanel's constructor, sometimes usingmodel
, sometimes using the redundant parameters. E.g.:So I'm going to get rid of the redundant parameters.
The text was updated successfully, but these errors were encountered: