Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use type-specific Properties and validation #111

Closed
pixelzoom opened this issue May 22, 2018 · 2 comments
Closed

use type-specific Properties and validation #111

pixelzoom opened this issue May 22, 2018 · 2 comments
Labels
dev:enhancement

Comments

@pixelzoom
Copy link
Contributor

Noticed while working on #109 and #110. This sim does not use type-specific Properties, and does not use Property validation features. That should be changed at some point, since it will make PhET-iO instrumentation easier.
pixelzoom referenced this issue May 22, 2018
@pixelzoom
add validValues for string Properties #109
8fd66f1 
Signed-off-by: Chris Malley <[email protected]>
@pixelzoom
Copy link
Contributor Author

12 occurrences of new Property in this sim, so this shouldn't take a lot of time.

pixelzoom added a commit that referenced this issue May 22, 2018
@pixelzoom
use type-specific Properties and validation #111
92da1aa 
Signed-off-by: Chris Malley <[email protected]>
@pixelzoom
Copy link
Contributor Author

Addressed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom