Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an aqua test for just a11y sims, with accessibility flag enabled <eom/> #24

Closed
zepumph opened this issue Mar 31, 2018 · 12 comments
Closed
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Mar 31, 2018

From phetsims/scenery#748

@zepumph zepumph self-assigned this Mar 31, 2018
zepumph added a commit that referenced this issue Apr 5, 2018
@zepumph
Copy link
Member Author

zepumph commented Apr 5, 2018

Tagging @mbarlow12 and @jessegreenberg so that they know that now in the aqua section of phetmarks you can now fuzzMouse and fuzzBoard just a11y sims (defaults to just a11y sims fuzzMouse). @jessegreenberg please review.

@jonathanolson
Copy link
Contributor

Would we want testing like this in continuous testing?

@zepumph
Copy link
Member Author

zepumph commented Apr 5, 2018

Although fuzzBoard option (second two query parameters checked) is likely broken for every sim, I think it is worth adding it so we can fix these problems. The fuzzMouse for specific a11y sims with ?accessibility would be very good to add (first and third query parameters together).

zepumph added a commit that referenced this issue Apr 5, 2018
zepumph added a commit that referenced this issue Apr 5, 2018
@jessegreenberg
Copy link
Contributor

This is really convenient @zepumph, thanks!

When I test coulombs-law, the browser hangs and I can't close the tab, does that happen for you?

For sims that are broken with fuzzBoard, it is not clear to me if problems are in a11y implementation or in the fuzzBoard test. If we add to CT right away I am worried things will be broken for some time. @zepumph would you be OK fixing errors before adding to CT?

@jessegreenberg
Copy link
Contributor

When I test coulombs-law, the browser hangs and I can't close the tab, does that happen for you?

Sorry, this might be because of local copy changes - I am investigating.

@zepumph
Copy link
Member Author

zepumph commented Apr 5, 2018

Where the list of testSims is dynamically the list of a11y sims (sorry I'm not being clear). Assigning to @jonathanolson

@jonathanolson
Copy link
Contributor

We actually don't run test-sims.html at all from CT, and I'm not aware of support for that to work.

Can I instead add the ?accessibility query parameter to the a11y sims (anything listed in perennial/data/accessibility), and have that be a separate testable mode for those sims? Would it need other query parameters or annotations?

@zepumph
Copy link
Member Author

zepumph commented Apr 10, 2018

That will be great! No other query params needed at this time (except fuzzMouse of course). Separate testable mode seems very nice.

Thank you.

@jonathanolson
Copy link
Contributor

Automated testing with the ?accessibility flag has been added to continuous testing, and is live.

@jessegreenberg
Copy link
Contributor

Thanks @jonathanolson! @zepumph is anything else needed for this issue?

@jessegreenberg jessegreenberg removed their assignment Apr 10, 2018
@zepumph
Copy link
Member Author

zepumph commented Apr 10, 2018

Nope all is good. Once we get fuzzBoard more stable, we will have @jonathanolson add that too, but that will be some time, since it's a pretty low priority I think. Closing

@zepumph zepumph closed this as completed Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants