-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add an aqua test for just a11y sims, with accessibility flag enabled <eom/> #24
Comments
Tagging @mbarlow12 and @jessegreenberg so that they know that now in the |
Would we want testing like this in continuous testing? |
Although fuzzBoard option (second two query parameters checked) is likely broken for every sim, I think it is worth adding it so we can fix these problems. The fuzzMouse for specific a11y sims with |
This is really convenient @zepumph, thanks! When I test coulombs-law, the browser hangs and I can't close the tab, does that happen for you? For sims that are broken with fuzzBoard, it is not clear to me if problems are in a11y implementation or in the fuzzBoard test. If we add to CT right away I am worried things will be broken for some time. @zepumph would you be OK fixing errors before adding to CT? |
Sorry, this might be because of local copy changes - I am investigating. |
@jonathanolson I will let you know when the keyboard fuzzer is ready for CT, for now please add the following link (adapted for CT) |
Where the list of testSims is dynamically the list of a11y sims (sorry I'm not being clear). Assigning to @jonathanolson |
We actually don't run test-sims.html at all from CT, and I'm not aware of support for that to work. Can I instead add the |
That will be great! No other query params needed at this time (except fuzzMouse of course). Separate testable mode seems very nice. Thank you. |
Automated testing with the ?accessibility flag has been added to continuous testing, and is live. |
Thanks @jonathanolson! @zepumph is anything else needed for this issue? |
Nope all is good. Once we get fuzzBoard more stable, we will have @jonathanolson add that too, but that will be some time, since it's a pretty low priority I think. Closing |
From phetsims/scenery#748
The text was updated successfully, but these errors were encountered: