Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we track other conditions in google analytics? #49

Open
samreid opened this issue Dec 10, 2019 · 1 comment
Open

Should we track other conditions in google analytics? #49

samreid opened this issue Dec 10, 2019 · 1 comment
Assignees

Comments

@samreid
Copy link
Member

samreid commented Dec 10, 2019

From this TODO, added by @jonathanolson in 33ce29f for https://github.com/phetsims/yotta/issues/30

  let loadType;
  // This is the iOS app
  if ( phet.chipper.queryParameters[ 'phet-app' ] ) {
    loadType = 'phet-app';
  }
  // For the Android app, see https://github.com/phetsims/phet-android-app/issues/16
  else if ( phet.chipper.queryParameters[ 'phet-android-app' ] ) {
    loadType = 'phet-android-app';
  }
  else if ( top !== self ) {
    // Checks to see if this sim is embedded - phetsims/chipper#50
    loadType = 'embedded';
  }
  // TODO Add additional conditions for tracking hits from the installer, etc.
  else {
    loadType = 'default';
  }

We are currently distinguishing between iOS app, android app, and embedded launches. Should we add other categories here? Assigning to @jonathanolson for initial comment.

@jonathanolson
Copy link
Contributor

Presumably we can change it to track whatever else we want, but I can't think of anything particularly important here. @kathy-phet, for html5 sims, do we want to track any other way people load sims? (Otherwise I think the TODO can be removed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants