Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move formatting rules to general rules #156

Closed
zepumph opened this issue Feb 26, 2021 · 1 comment
Closed

Move formatting rules to general rules #156

zepumph opened this issue Feb 26, 2021 · 1 comment
Assignees
@samreid

Comments

@zepumph
Copy link
Member

zepumph commented Feb 26, 2021

From #150, but we don't want to clog that up as we move and auto fix issues.
zepumph added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@zepumph
move no-template-curly-in-string to general rules, phetsims/phet-info…
2f5d063 
…#156
zepumph added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@zepumph
get rid of lines-around-comment, phetsims/phet-info#156
c658164
zepumph added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@zepumph
remove camelcase from formatting, phetsims/phet-info#156
b14b068
zepumph added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@zepumph
add brace-style to general rules, phetsims/phet-info#156
b8c2615
zepumph added a commit to phetsims/binder that referenced this issue Feb 26, 2021
@zepumph
add brace-style to general rules, phetsims/phet-info#156
5402290
zepumph added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@zepumph
remove block-spacing from format rules, phetsims/phet-info#156
3fad360
zepumph added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@zepumph
move space-before-function-paren, phetsims/phet-info#156
05e7588
zepumph added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@zepumph
remove prefer-object-spread from formatting rules, phetsims/phet-info…
fe4f3d0 
…#156
zepumph added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@zepumph
update eol-last to be knit picky, phetsims/phet-info#156
45532f1
zepumph added a commit to phetsims/least-squares-regression that referenced this issue Feb 26, 2021
@zepumph
add brace-style to general rules, phetsims/phet-info#156
844fb88
samreid added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@samreid
Remove operator-assignment rule, see phetsims/phet-info#156
24c8400
samreid added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@samreid
Remove indent and object-curly-newline rules, see phetsims/phet-info#156
6b169a9
samreid added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@samreid
Increase max number of lines, see phetsims/phet-info#156
f561855
samreid added a commit to phetsims/scenery-phet that referenced this issue Feb 26, 2021
@samreid
Disallow too many empty lines, see phetsims/phet-info#156
c247193
samreid added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@samreid
Disallow too many empty lines, see phetsims/phet-info#156
8405347
zepumph added a commit to phetsims/binder that referenced this issue Feb 26, 2021
@zepumph
lint as node, phetsims/phet-info#156
09b4b3b
zepumph added a commit to phetsims/states-of-matter that referenced this issue Feb 26, 2021
@zepumph
add keyword-spacing to lint rules, phetsims/phet-info#156
2b1fa82
zepumph added a commit to phetsims/joist that referenced this issue Feb 26, 2021
@zepumph
add keyword-spacing to lint rules, phetsims/phet-info#156
4c2aa68
zepumph added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@zepumph
add keyword-spacing to lint rules, phetsims/phet-info#156
9d5f6c0
zepumph added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@zepumph
remove lines-around-directive from formatting rules, phetsims/phet-in…
d33507f 
…fo#156
zepumph added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@zepumph
uncomment block, phetsims/phet-info#156
571a4bc
zepumph added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@zepumph
delete newline-per-chained-call, phetsims/phet-info#156
326688c
samreid added a commit to phetsims/least-squares-regression that referenced this issue Feb 26, 2021
@samreid
Promote no-multi-spaces to main rules, see phetsims/phet-info#156
ea0ca9f
samreid added a commit to phetsims/aqua that referenced this issue Feb 26, 2021
@samreid
Promote no-multi-spaces to main rules, see phetsims/phet-info#156
944fce6
samreid added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@samreid
Promote no-multi-spaces to main rules, see phetsims/phet-info#156
175d5bb
samreid added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@samreid
Remove no-unneeded-ternary rule, see phetsims/phet-info#156
6e255f6
zepumph added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@zepumph
add func-name-matching, phetsims/phet-info#156
6c6acd9
samreid added a commit to phetsims/chipper that referenced this issue Feb 26, 2021
@samreid
Remove unlikely rules, see phetsims/phet-info#150 and phetsims/phet-i…
497708a 
…nfo#156
@zepumph
Copy link
Member Author

zepumph commented Feb 26, 2021

@samreid and I went through all formatting issues, and added them to general when we found that they were (a) already being followed well by our project, and (b), that webstorm fixes them with auto format nicely.

Closing

@zepumph zepumph closed this as completed Feb 26, 2021
@zepumph zepumph mentioned this issue Feb 26, 2021
Closed
@samreid samreid mentioned this issue Mar 1, 2021
Closed
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
move no-template-curly-in-string to general rules, phetsims/phet-info…
44bed48 
…#156
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
get rid of lines-around-comment, phetsims/phet-info#156
0eaf9ae
zepumph pushed a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@samreid @zepumph
Remove operator-assignment rule, see phetsims/phet-info#156
28fd007
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
remove camelcase from formatting, phetsims/phet-info#156
97eedc7
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
add brace-style to general rules, phetsims/phet-info#156
948fc90
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
remove block-spacing from format rules, phetsims/phet-info#156
46ba4fe
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
move space-before-function-paren, phetsims/phet-info#156
7b6d614
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
remove prefer-object-spread from formatting rules, phetsims/phet-info…
5f3c9e8 
…#156
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
update eol-last to be knit picky, phetsims/phet-info#156
7b06f8b
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
add keyword-spacing to lint rules, phetsims/phet-info#156
b11e61f
zepumph pushed a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@samreid @zepumph
Remove indent and object-curly-newline rules, see phetsims/phet-info#156
9521d0b
zepumph pushed a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@samreid @zepumph
Increase max number of lines, see phetsims/phet-info#156
12f08f8
zepumph pushed a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@samreid @zepumph
Disallow too many empty lines, see phetsims/phet-info#156
63e7971
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
remove lines-around-directive from formatting rules, phetsims/phet-in…
f0f8fc2 
…fo#156
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
uncomment block, phetsims/phet-info#156
a39869a
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
delete newline-per-chained-call, phetsims/phet-info#156
8b190bd
zepumph pushed a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@samreid @zepumph
Promote no-multi-spaces to main rules, see phetsims/phet-info#156
bee4c79
zepumph pushed a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@samreid @zepumph
Remove no-unneeded-ternary rule, see phetsims/phet-info#156
6980e02
zepumph added a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@zepumph
add func-name-matching, phetsims/phet-info#156
22318c4
zepumph pushed a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@samreid @zepumph
Remove unlikely rules, see phetsims/phet-info#150 and phetsims/phet-i…
8733c14 
…nfo#156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph