Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/master'
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed May 14, 2020
2 parents 06194d6 + 2d07ebb commit dd3fdb9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion checklists/code_review_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ For a sim repository named “my-repo”, the general structure should look like
- [ ] Are there any GitHub branches that are no longer needed and should be deleted?
- [ ] Does `model.md` adequately describe the model, in terms appropriate for teachers?
- [ ] Does `implementation-notes.md` adequately describe the implementation, with an overview that will be useful to future maintainers?
- [ ] Are sim-specific query parameters (if any) identified and documented in one .js file in js/common/ or js/ (if there is no common/)? The .js file should be named `{{PREFIX}}QueryParameters.js`, for example ArithmeticQueryParameters.js for the aritmetic repository (or FBQueryParameters.js for Function Builder, where `FB` is the common prefix)
- [ ] Sim-specific query parameters (if any) should be identified and documented in one .js file in js/common/ or js/ (if there is no common/). The .js file should be named `{{PREFIX}}QueryParameters.js`, for example ArithmeticQueryParameters.js for the aritmetic repository, or FBQueryParameters.js for Function Builder (where the `FB` prefix is used). Query parameters that are public-facing should be identified using `public: true` in the schema.

## **Coding Conventions**

Expand Down
1 change: 1 addition & 0 deletions checklists/sim_new_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
- [ ] **Pre-publication items**
- [ ] Main screenshot (read [this](https://github.com/phetsims/QA/blob/master/doc/qa-book.md#screenshots))
- [ ] Verify credits with lead (Team, Contributors, QA, Graphic Arts, Sound Design, any Thanks)
- [ ] Add CT tests for public query parameters
- [ ] **Published** (Date: //)
- [ ] Mark the sim as published in [responsible_dev.md](https://github.com/phetsims/phet-info/blob/master/sim-info/responsible_dev.md)

Expand Down

0 comments on commit dd3fdb9

Please sign in to comment.