Skip to content

Commit

Permalink
note to check license.json for why some resources might not have an a…
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Jul 13, 2017
1 parent ba7bdb2 commit d894b90
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion checklists/code_review_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ All JavaScript source should be in the js/ directory. There should be a subdirec
myRepo.js
```

- [ ] Is there a file in assets/ for every resource file in audio/ and images/? Note that there is *not necessarily* a 1:1 correspondence between asset and resource files; for example, several images may be in the same .ai file.
- [ ] Is there a file in assets/ for every resource file in audio/ and images/? Note that there is *not necessarily* a 1:1 correspondence between asset and resource files; for example, several images may be in the same .ai file. Check license.json for possible documentation of why some reesources might not have a corresponding asset file.
- [ ] Was the README.md generated by `grunt published-README` or `grunt unpublished-README`?
- [ ] Does package.json refer to any dependencies that are not used by the sim?
- [ ] Does sim-config.js refer to any dependencies that are not used by the sim? Note: `ifphetio` plugin and `PHET_IO` dependencies should be included in all config files.
Expand Down

0 comments on commit d894b90

Please sign in to comment.