Skip to content

Commit

Permalink
Cleaned up constructors, see phetsims/faradays-law#86
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Nov 20, 2017
1 parent 3074392 commit 9eeaa09
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion checklists/code_review_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,9 @@ var energyImage = require( 'image!ENERGY/energy.png' );
var kineticAudio = require( 'audio!ENERGY/energy' );
```

- [ ] Do the `@author` annotations seem correct?
- [ ] Do the `@author` annotations seem correct?

- [ ] Are all constructors marked with `@constructor`? That will make them easier to search and review.

- [ ] For constructors, use parameters for things that don’t have a default. Use options for things that have a default value. This improves readability at the call site, especially when the number of parameters is large. It also eliminates order dependency that is required by using parameters.

Expand Down

0 comments on commit 9eeaa09

Please sign in to comment.