Skip to content

Commit

Permalink
Add a checklist item about using EnabledProperty, see phetsims/axon#340
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Nov 16, 2020
1 parent abe5d5d commit 9cddf1f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions checklists/code_review_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -697,3 +697,5 @@ determining whether `toStateObject` should use `null` or `undefined` values.
- [ ] PhET prefers to use the term "position" to refer to the physical (x,y) position of objects. This applies to both
brands, but is more important for the PhET-iO API. See https://github.com/phetsims/phet-info/issues/126
- [ ] Are your IOType state methods violating the API of the core type by accessing private fields?
- [ ] When defining a boolean Property to indicate whether something is enabled, use `AXON/EnabledProperty`. This
should be done in both the model and the view.

0 comments on commit 9cddf1f

Please sign in to comment.