Skip to content

Commit

Permalink
Update code_review_checklist.md
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph authored Sep 22, 2017
1 parent 07772fa commit 8861233
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion checklists/code_review_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ All JavaScript source should be in the js/ directory. There should be a subdirec
- [ ] Is there a file in assets/ for every resource file in audio/ and images/? Note that there is *not necessarily* a 1:1 correspondence between asset and resource files; for example, several related images may be in the same .ai file. Check license.json for possible documentation of why some reesources might not have a corresponding asset file.
- [ ] Was the README.md generated by `grunt published-README` or `grunt unpublished-README`?
- [ ] Does package.json refer to any dependencies that are not used by the sim?
- [ ] Does sim-config.js refer to any dependencies that are not used by the sim? Note: `ifphetio` plugin and `PHET_IO` dependencies should be included in all config files.
- [ ] Does sim-config.js refer to any dependencies that are not used by the sim? Note: `ifphetio` plugin and `PHET_IO` dependencies should be included in all config files. Also note that `REPOSITORY` is used in all sims by joist and tandem.
- [ ] Does package.json contain phetLibs for all non-default entries in sim-config.json?
- [ ] Is the LICENSE file correct? (GPL v3 for sims, MIT for common code)
- [ ] Does .gitignore match the one in simula-rasa?
Expand Down

0 comments on commit 8861233

Please sign in to comment.