Skip to content

Commit

Permalink
Remove ColorProfile.js, see phetsims/scenery-phet#515
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Jul 19, 2021
1 parent a57ff3b commit 39416f4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion checklists/code_review_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,9 @@ For a sim repository named “my-repo”, the general structure should look like
- [ ] Does `implementation-notes.md` adequately describe the implementation, with an overview that will be useful to future maintainers?
- [ ] Sim-specific query parameters (if any) should be identified and documented in one .js file in js/common/ or js/ (if there is no common/). The .js file should be named `{{PREFIX}}QueryParameters.js`, for example ArithmeticQueryParameters.js for the aritmetic repository, or FBQueryParameters.js for Function Builder (where the `FB` prefix is used).
- [ ] Query parameters that are public-facing should be identified using `public: true` in the schema.
- [ ] All sims should have a ColorProfile, named {{PREFIX}}ColorProfile.js, even if they have a single (default)
- [ ] All sims should use a color file and ProfileColorProperty where appropriate, even if they have a single (default)
profile. See https://github.com/phetsims/scenery-phet/issues/642.
TODO: https://github.com/phetsims/scenery-phet/issues/515 decide the name for the colors file.

## **Coding Conventions**

Expand Down

0 comments on commit 39416f4

Please sign in to comment.