Skip to content

Commit

Permalink
https://github.com/phetsims/chipper/issues/728
Browse files Browse the repository at this point in the history
restore checklist item for toFixed
  • Loading branch information
pixelzoom authored Jan 31, 2019
1 parent 546ff36 commit 32926ac
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions checklists/code_review_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,10 @@ addListener: function( listener ) { /*...*/ }
* Regex for property assignment like `x.y = something`: `[\w]+\.[\w]+\s=`
* Regex for function declarations: `[\w]+: function\(`
#### **Math Libraries**
- [ ] `DOT/Util.toFixed` or `DOT/Util.toFixedNumber` should be used instead of `toFixed`. JavaScript's `toFixed` is notoriously buggy. Behavior differs depending on browser, because the spec doesn't specify whether to round or floor.
#### IE11
- [ ] No usage of `Number.parseInt()`
- [ ] No usage of `Array.prototype.find`
Expand Down

0 comments on commit 32926ac

Please sign in to comment.