Skip to content

Commit

Permalink
#88
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom authored Jun 8, 2020
1 parent dc238ed commit 277c1a5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions checklists/code_review_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,7 @@ Because JavaScript lacks visibility modifiers (public, protected, private), PhET
- [ ] Does the organization and structure of the code make sense? Do the model and view contain types that you would expect (or guess!) by looking at the sim? Do the names of things correspond to the names that you see in the user interface?
- [ ] Are appropriate design patterns used? See [phet-software-design-patterns.md](https://github.com/phetsims/phet-info/blob/master/doc/phet-software-design-patterns.md). If new or inappropriate patterns are identified, create an issue.
- [ ] Is inheritance used where appropriate? Does the type hierarchy make sense?
- [ ] Is composition favored over inheritance where appropriate? See https://en.wikipedia.org/wiki/Composition_over_inheritance.
- [ ] Is there any unnecessary coupling? (e.g., by passing large objects to constructors, or exposing unnecessary properties/functions)
- [ ] Is there too much unnecessary decoupling? (e.g. by passing all of the properties of an object independently instead of passing the object itself)?
- [ ] Are the source files reasonable in size? Scrutinize large files with too many responsibilities - can responsibilities be broken into smaller delegates?
Expand Down

0 comments on commit 277c1a5

Please sign in to comment.