-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle EnumerationIO and EnumerationDeprecatedIO #97
Comments
|
…le to tandem (with history), phetsims/phet-core#97
…le to tandem (with history), phetsims/phet-core#97
…le to tandem (with history), phetsims/phet-core#97
…le to tandem (with history), phetsims/phet-core#97
Alright, with only a limited addition of API in EnumerationDeprecated, I was able to consolidate EnumerationIO types. There is now just a single IOType, in tandem, that both EnumerationDeprecated and Enumeration use. I think that this issue is ready for review by @samreid once everything get's pushed. |
…le to tandem (with history), phetsims/phet-core#97
…le to tandem (with history), phetsims/phet-core#97
…le to tandem (with history), phetsims/phet-core#97
…le to tandem (with history), phetsims/phet-core#97
…le to tandem (with history), phetsims/phet-core#97
Most important for the review @samreid: will you please make sure that the changes to ts-config files are as expected. I exclusively removed include/exclude paths, but they all seemed like workarounds, so I hope all is well here! |
I reviewed all the commits and didn't see any problems. I skimmed the changes in tsconfig files and they seem reasonable. I think |
From working on renaming in #95
Steps for this issue:
EnumerationIO
.We don't think it will cause complications with PhET-iO to have them share the same name for PhET-iO because each IOType is parametrized on the actual instance of enumeration, so we know the right values will be given by the PhET-iO system.
The text was updated successfully, but these errors were encountered: